From: Dan Malek <dan@embeddededge•com>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Paul Mackerras <paulus@samba•org>,
linux-ppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH] add big endian version of ld_/st_ IO access macros and convert main 8xx code to use it
Date: Wed, 7 Sep 2005 20:42:42 -0400 [thread overview]
Message-ID: <00a1f47bb2edbbc001c2267191aa36f0@embeddededge.com> (raw)
In-Reply-To: <1126139332.29803.0.camel@gaston>
On Sep 7, 2005, at 8:28 PM, Benjamin Herrenschmidt wrote:
> I'm not fan of the approach. You should use in_/out_ macros for IOs. If
> you don't need eieio on 8xx , then just #ifdef it out of the
> implementation of these.
Yeah, #ifdef :-) That patch wouldn't go anywhere (well,
to /dev/null perhaps).
We can just use the in_/out_ macros that are there. The eieio
doesn't hurt anything on the 8xx.
Thanks.
-- Dan
next prev parent reply other threads:[~2005-09-08 0:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 23:03 [PATCH] add big endian version of ld_/st_ IO access macros and convert main 8xx code to use it Marcelo Tosatti
2005-09-08 0:28 ` Benjamin Herrenschmidt
2005-09-08 0:42 ` Dan Malek [this message]
2005-09-08 0:55 ` Benjamin Herrenschmidt
2005-09-08 0:58 ` Marcelo Tosatti
2005-09-08 4:27 ` Paul Mackerras
2005-09-08 13:56 ` Dan Malek
2005-09-08 19:34 ` Marcelo Tosatti
2005-09-08 0:51 ` Marcelo Tosatti
2005-09-08 1:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a1f47bb2edbbc001c2267191aa36f0@embeddededge.com \
--to=dan@embeddededge$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox