Subject: RE: [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()

From: "Joakim Tjernlund" <[email-masked]>
Date: Wed, 23 Apr 2008 23:55:11 +0200

> -----Original Message-----
> From: linuxppc-dev-bounces+joakim.tjernlund=[email-masked] [mailto:linuxppc-dev-
> bounces+joakim.tjernlund=[email-masked]] On Behalf Of Roel Kluin
> Sent: den 23 april 2008 22:55
> To: [email-masked]; [email-masked]
> Cc: [email-masked]; [email-masked]; lkml
> Subject: [PATCH 1/2] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()
> 
> mpc83xx_spi->irq is unsigned, so the test fails
> 
> Signed-off-by: Roel Kluin <[email-masked]>

hmm, I got a pretty large 83xx spi patch queued at dbrownell. I hope
that one can be applied first. Then you probably need to rediff this patch.

David, any progress on my patch?

 Jocke
> ---
> diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
> index be15a62..033fd51 100644
> --- a/drivers/spi/spi_mpc83xx.c
> +++ b/drivers/spi/spi_mpc83xx.c
> @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev)
>  		goto put_master;
>  	}
> 
> -	mpc83xx_spi->irq = platform_get_irq(dev, 0);
> -
> -	if (mpc83xx_spi->irq < 0) {
> -		ret = -ENXIO;
> +	ret = platform_get_irq(dev, 0);
> +	if (ret < 0)
>  		goto unmap_io;
> -	}
> +
> +	mpc83xx_spi->irq = ret;
> +	ret = 0;
> 
>  	/* Register for SPI Interrupt */
>  	ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
> 
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>