From: Ricardo Scop <scop@digitel•com.br>
To: Joakim Tjernlund <Joakim.Tjernlund@lumentis•se>,
linuxppc-embedded@lists•linuxppc.org
Subject: Re: [PATCH] arch/ppc/8xx_io/enet.c
Date: Wed, 23 Oct 2002 13:32:32 -0200 [thread overview]
Message-ID: <02102313323200.01073@scop.digitel.com.br> (raw)
In-Reply-To: <200210230751.g9N7pN4d024262@blooper.utfors.se>
On Wednesday 23 October 2002 05:51, Joakim Tjernlund wrote:
> On Monday 21 October 2002 15:13, Joakim Tjernlund wrote:
> > Hi
> >
> > Here is a patch to drop the expensive memcpy of received ethernet frames
> > in interrupt context. I have not done any bench marking, but mounting a
> > NFS rootfs feels faster.
> >
> > I am using a heavily modified enet.c in my system, but I think I got the
> > patch correct.
> >
> > Also fixed a bug in set_multicast_list(), move the dmi list forward when
> > walking it(dmi = dmi->next;)
> >
> > Comments? Anyone care to do some benchmarking?
>
> No comments so far, no one interested in this?
I'm interested! Indeed, I adapted and tested your patch in a 8260 FCC fast
ethernet driver and it worked fine I had a 20% increase in routing
throughput with the patch installed!
The bug fix in set_multicast_list worked too. But, since there's a continue
clause inside the for command in this routine, I would suggest that the
(dmi=dmi->next) command go inside the for increment clause, instead of the
place you've put it; that is:
for (...;...; i++, dmi = dmi->next) {...}
>
> A question, why do enet.c pass bad frames to netif_rx? Only late collisions
> are disregarded, the rest is passed on.
IMHO, this is another bug...
>
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-10-23 15:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-23 7:51 [PATCH] arch/ppc/8xx_io/enet.c Joakim Tjernlund
2002-10-23 15:32 ` Ricardo Scop [this message]
2002-10-23 15:44 ` Ricardo Scop
2002-10-25 16:02 ` dc* (Data Cache) instructions in mem*() and *_page() functions not used on 8xx Joakim Tjernlund
2002-10-27 23:23 ` Joakim Tjernlund
2002-10-29 15:27 ` Dan Malek
2002-10-29 16:02 ` Joakim Tjernlund
2002-10-29 16:23 ` Dan Malek
2002-10-29 18:07 ` Joakim Tjernlund
2002-11-01 11:14 ` Joakim Tjernlund
2002-11-01 17:33 ` Dan Malek
2002-11-01 19:27 ` Joakim Tjernlund
2002-11-04 2:09 ` Dan Malek
2002-11-04 10:25 ` Joakim Tjernlund
2002-10-24 7:14 ` [PATCH] arch/ppc/8xx_io/enet.c Joakim Tjernlund
2002-10-24 10:12 ` Steven Scholz
2002-10-24 10:14 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2002-10-21 13:13 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02102313323200.01073@scop.digitel.com.br \
--to=scop@digitel$(echo .)com.br \
--cc=Joakim.Tjernlund@lumentis$(echo .)se \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox