From: "Joakim Tjernlund" <joakim.tjernlund@transmode•se>
To: <avorontsov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org
Subject: RE: [RFC][PATCH] MPC832x_RDB: update dts to use spi, registermmc_spi stub
Date: Thu, 26 Jul 2007 21:40:23 +0200 [thread overview]
Message-ID: <02bd01c7cfbc$cf213610$02ac10ac@Jocke> (raw)
In-Reply-To: <20070726154747.GA6930@localhost.localdomain>
> -----Original Message-----
> From: Anton Vorontsov [mailto:avorontsov@ru•mvista.com]
> Sent: den 26 juli 2007 17:48
> To: Joakim Tjernlund
> Cc: linuxppc-dev@ozlabs•org
> Subject: Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi,
> registermmc_spi stub
>
> On Thu, Jul 26, 2007 at 05:36:06PM +0200, Joakim Tjernlund wrote:
> [...]
> > > spi@4c0 {
> > > device_type = "spi";
> > > + device-id = <1>;
> > > compatible = "fsl_spi";
> > > reg = <4c0 40>;
> > > interrupts = <2>;
> > > interrupt-parent = <&qeic>;
> > > - mode = "cpu";
> > > + mode = "qe";
> >
> > The driver is still using "cpu" mode. It just happens that
> the cpu mode for QE
> > enabled CPUs isn't 100% compatible with the defacto cpu
> mode used by other CPU:s.
>
> Yup, indeed.
>
> > So mode should probably be "cpu_qe" or, even better, if the
> drver could
>
> That's easy to change, thanks.
>
> > autodetect that it is running on a QE enabled CPU and
> adjust accordinly.
> > Maybe the Freescale guys have some ideas how to do that.
>
> Ok. Well, for now could we use machine_is() for kind of autodetect?
> Or it's better leave it as is, and just rename mode to cpu_qe?
Unless the DTS guys thinks otherwise, just rename to "cpu_qe".
"qe" would then be reserved for true QE mode.
Jocke
next prev parent reply other threads:[~2007-07-26 19:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 13:57 [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub Anton Vorontsov
2007-07-26 15:36 ` Joakim Tjernlund
2007-07-26 15:47 ` Anton Vorontsov
2007-07-26 19:40 ` Joakim Tjernlund [this message]
2007-07-27 7:55 ` [RFC][PATCH] MPC832x_RDB: update dts to use spi, registermmc_spi stub Kumar Gala
2007-07-31 21:47 ` Segher Boessenkool
2007-07-27 8:14 ` [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub Kumar Gala
2007-07-27 11:45 ` Anton Vorontsov
2007-07-27 13:55 ` Kumar Gala
2007-07-27 16:40 ` Scott Wood
2007-07-31 22:00 ` Segher Boessenkool
2007-08-01 17:43 ` Scott Wood
2007-08-06 18:24 ` Segher Boessenkool
2007-07-31 22:06 ` Segher Boessenkool
2007-08-01 13:29 ` Anton Vorontsov
2007-08-06 18:18 ` Segher Boessenkool
2007-08-07 10:53 ` Anton Vorontsov
2007-08-07 16:11 ` Segher Boessenkool
2007-08-01 19:16 ` Kim Phillips
2007-08-06 18:25 ` Segher Boessenkool
2007-08-06 21:31 ` Kim Phillips
2007-08-06 22:08 ` Segher Boessenkool
2007-07-31 22:10 ` Segher Boessenkool
2007-08-01 12:34 ` Anton Vorontsov
2007-08-06 18:09 ` Segher Boessenkool
2007-08-06 18:50 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02bd01c7cfbc$cf213610$02ac10ac@Jocke' \
--to=joakim.tjernlund@transmode$(echo .)se \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox