From: Segher Boessenkool <segher@kernel•crashing.org>
To: Stuart Yoder <b08248@freescale•com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH] powerpc: update interrupt info in booting-without-of.txt
Date: Wed, 28 Feb 2007 00:23:30 +0100 [thread overview]
Message-ID: <02cb84d7709d1b86ce33030c297c0de1@kernel.crashing.org> (raw)
In-Reply-To: <200702272223.l1RMNKcF030373@ld0164-tx32.am.freescale.net>
> +Devices that generate interrupts have an 'interrupt parent' in
> +the interrupt tree. An interrupt parent can be explicitly
> +defined through the interrupt-parent property. For nodes with
> +no interrupt-parent, the interrupt parent is assumed to be
> +the node's _device tree_ parent.
Or its parent, or its grandparent, etc.
> +The encoding of an interrupt specifier is determined by the
> +domain (or nexus)
Domain. An interrupt nexus is to the interrupt tree
what a node is to the device tree.
> +The PCI bus binding specifies a #interrupt-cell value of 1 to encode
> +which interrupt line (INTA,INTB,INTC,INTD) is used.
s/line/pin/ to agree with PCI terminology.
> +The interrupt-parent property is specified to define an explicit
> +link between a device node and its interrupt parent in
> +the interrupt tree. The value of interrupt-parent is the
> +phandle to the parent node.
phandle _of_ the parent node please.
> +If the interrupt-parent property is not defined for a node, it's
> +interrupt parent is assumed to be it's device tree_ parent.
Same thing again. You missed an underscore, too.
> +OpenPIC interrupt controllers required 2 cells to encode
s/required/require/
> +ISA PIC interrupt controllers required 2 cells to encode
same thing
Looks good otherwise, thanks.
Segher
next prev parent reply other threads:[~2007-02-27 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 22:23 [PATCH] powerpc: update interrupt info in booting-without-of.txt Stuart Yoder
2007-02-27 23:23 ` Segher Boessenkool [this message]
2007-02-28 0:46 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cb84d7709d1b86ce33030c297c0de1@kernel.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=b08248@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox