From: "Joakim Tjernlund" <joakim.tjernlund@transmode•se>
To: "'Timur Tabi'" <timur@freescale•com>
Cc: 'linuxppc-dev' <linuxppc-dev@ozlabs•org>
Subject: RE: latest linux git doesn't compile ucc_geth_phy.c and ucc_geth.c
Date: Wed, 13 Dec 2006 21:47:37 +0100 [thread overview]
Message-ID: <034701c71ef7$ec7f7580$020120ac@Jocke> (raw)
In-Reply-To: <45803CE3.4030600@freescale.com>
> -----Original Message-----
> From: Timur Tabi [mailto:timur@freescale•com]
> Sent: den 13 december 2006 18:48
> To: joakim.tjernlund@transmode•se
> Cc: linuxppc-dev
> Subject: Re: latest linux git doesn't compile ucc_geth_phy.c
> and ucc_geth.c
>
> Joakim Tjernlund wrote:
> > drivers/net/ucc_geth.c:4083:45: macro "INIT_WORK" passed 3
> arguments,
> > but takes just 2
> > drivers/net/ucc_geth.c: In function `ucc_geth_open':
> > drivers/net/ucc_geth.c:4083: error: `INIT_WORK' undeclared
> (first use in
> > this function)
> > drivers/net/ucc_geth.c:4083: error: (Each undeclared identifier is
> > reported only once
> > drivers/net/ucc_geth.c:4083: error: for each function it
> appears in.)
> > drivers/net/ucc_geth.c: At top level:
> > drivers/net/ucc_geth.c:3924: warning: 'ugeth_phy_change'
> defined but not
> > used
> > make[2]: *** [drivers/net/ucc_geth.o] Error 1
> >
> > drivers/net/ucc_geth_phy.c:71: error: conflicting types for
> 'phy_read'
> > include/linux/phy.h:355: error: previous declaration of
> 'phy_read' was
> > here
> > drivers/net/ucc_geth_phy.c:71: error: conflicting types for
> 'phy_read'
> > include/linux/phy.h:355: error: previous declaration of
> 'phy_read' was
> > here
> > drivers/net/ucc_geth_phy.c:72: error: conflicting types for
> 'phy_write'
> > include/linux/phy.h:356: error: previous declaration of
> 'phy_write' was
> > here
> > drivers/net/ucc_geth_phy.c:72: error: conflicting types for
> 'phy_write'
> > include/linux/phy.h:356: error: previous declaration of
> 'phy_write' was
> > here
>
> I just posted two patches to linuxppc-dev that fix these
> problems. The message
> are titled:
>
> [PATCH] Update ucc_geth.c for new workqueue structure
> [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c
>
> I've tested these on an 8360EMDS, and Kumar has reviewed and
> signed off on the
> code, so I think they're good. Please let me know if they're not.
Works for me, thanks
Jocke
next prev parent reply other threads:[~2006-12-13 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 12:44 latest linux git doesn't compile ucc_geth_phy.c and ucc_geth.c Joakim Tjernlund
2006-12-13 14:36 ` Kumar Gala
2006-12-13 17:48 ` Timur Tabi
2006-12-13 20:47 ` Joakim Tjernlund [this message]
2006-12-13 21:34 ` Kumar Gala
2006-12-17 23:04 ` Joakim Tjernlund
2006-12-18 15:56 ` Timur Tabi
2006-12-18 18:44 ` Kumar Gala
2007-01-05 13:19 ` Joakim Tjernlund
2007-01-13 16:51 ` Joakim Tjernlund
2007-01-15 16:33 ` Kumar Gala
2007-01-16 6:44 ` Li Yang-r58472
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034701c71ef7$ec7f7580$020120ac@Jocke' \
--to=joakim.tjernlund@transmode$(echo .)se \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox