From: David Hildenbrand <david@redhat•com>
To: Peter Xu <peterx@redhat•com>
Cc: Dave Hansen <dave.hansen@linux•intel.com>,
linux-mm@kvack•org,
Christophe Leroy <christophe.leroy@csgroup•eu>,
Dan Williams <dan.j.williams@intel•com>,
Dave Jiang <dave.jiang@intel•com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux•ibm.com>,
x86@kernel•org, Hugh Dickins <hughd@google•com>,
Matthew Wilcox <willy@infradead•org>,
Ingo Molnar <mingo@redhat•com>, Huang Ying <ying.huang@intel•com>,
Alex Thorlton <athorlton@sgi•com>,
Rik van Riel <riel@surriel•com>,
Nicholas Piggin <npiggin@gmail•com>,
Borislav Petkov <bp@alien8•de>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
Thomas Gleixner <tglx@linutronix•de>,
Vlastimil Babka <vbabka@suse•cz>,
Oscar Salvador <osalvador@suse•de>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
Rick P Edgecombe <rick.p.edgecombe@intel•com>,
Mel Gorman <mgorman@techsingularity•net>
Subject: Re: [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES
Date: Tue, 6 Aug 2024 15:02:00 +0200 [thread overview]
Message-ID: <054324a3-bc77-426f-a751-06700aad394e@redhat.com> (raw)
In-Reply-To: <Zq-Y3qs5_PZW04bt@x1n>
> Right.
>
> I don't have a reason to change numa_pte_updates semantics yet so far, but
> here there's the problem where numa_huge_pte_updates can be ambiguous when
> there is even PUD involved.
>
> In general, I don't know how I should treat this counter in PUD path even
> if NUMA isn't involved in dax yet; it can be soon involved if we move on
> with using this same path for hugetlb, or when 1G thp can be possible (with
> Yu Zhao's TAO?).
We shouldn't bother about it in the PUD path at all I think. Especially
as long as NUMA hinting doesn't apply to any of what we would handle on
the PUD path :)
>
> One other thing I can do is I drop this patch, ignore NUMA_HUGE_PTE_UPDATES
> in PUD dax processing for now. It'll work for this series, but it'll still
> be a problem later. I figured maybe we should simply drop it from now.
It probably shouldn't block your other fixes and we should likely
discuss that separately.
I agree that we should look into dropping that PMD counter completely.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-08-06 13:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 19:21 [PATCH v3 0/8] mm/mprotect: Fix dax puds Peter Xu
2024-07-15 19:21 ` [PATCH v3 1/8] mm/dax: Dump start address in fault handler Peter Xu
2024-07-31 12:04 ` David Hildenbrand
2024-08-02 22:43 ` Peter Xu
2024-07-15 19:21 ` [PATCH v3 2/8] mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES Peter Xu
2024-07-31 12:18 ` David Hildenbrand
2024-08-04 15:06 ` Peter Xu
2024-08-06 13:02 ` David Hildenbrand [this message]
2024-08-06 16:26 ` Peter Xu
2024-08-06 16:32 ` David Hildenbrand
2024-08-06 16:51 ` Peter Xu
2024-07-15 19:21 ` [PATCH v3 3/8] mm/mprotect: Push mmu notifier to PUDs Peter Xu
2024-07-15 19:21 ` [PATCH v3 4/8] mm/powerpc: Add missing pud helpers Peter Xu
2024-07-15 19:21 ` [PATCH v3 5/8] mm/x86: Make pud_leaf() only cares about PSE bit Peter Xu
2024-07-31 12:22 ` David Hildenbrand
2024-07-15 19:21 ` [PATCH v3 6/8] mm/x86: arch_check_zapped_pud() Peter Xu
2024-07-31 12:23 ` David Hildenbrand
2024-07-15 19:21 ` [PATCH v3 7/8] mm/x86: Add missing pud helpers Peter Xu
2024-07-15 19:21 ` [PATCH v3 8/8] mm/mprotect: fix dax pud handlings Peter Xu
2024-07-25 18:29 ` James Houghton
2024-07-25 22:41 ` Peter Xu
2024-07-26 0:23 ` James Houghton
2024-07-26 11:56 ` Peter Xu
2024-07-15 20:00 ` [PATCH v3 0/8] mm/mprotect: Fix dax puds Peter Xu
2024-07-24 15:15 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=054324a3-bc77-426f-a751-06700aad394e@redhat.com \
--to=david@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=athorlton@sgi$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dave.jiang@intel$(echo .)com \
--cc=hughd@google$(echo .)com \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mgorman@techsingularity$(echo .)net \
--cc=mingo@redhat$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=osalvador@suse$(echo .)de \
--cc=peterx@redhat$(echo .)com \
--cc=rick.p.edgecombe@intel$(echo .)com \
--cc=riel@surriel$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ying.huang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox