Subject: Re: [PATCH 2/5] Add legacy devices to mpc8641_hpcn.dts

From: Segher Boessenkool <[email-masked]>
Date: Thu, 17 May 2007 01:40:27 +0200

>>>> +			isa@f0 {
>> isa@1e

You didn't reply to this one, but you *really* need
to fix it.

>>>> +				8042@60 {
>>>> +					device_type = "8042";
>>
>> Drop the device_type.  A number as a name isn't
>> all that great, either.
>
> Currently in order for the i8042 devices to be initialized,
> check_legacy_ioport() must find a node with device_type "8042".

So fix that :-)

> Is there a recommended "compatible" property for a standard PC-like 
> CMOS
> RTC?

None in the bindings that I know of.  It typically would
be the model name/number of the oldest chip used, or one
that is very commonly used.

Segher