From: Michael Neuling <mikey@neuling•org>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Andreas Schwab <schwab@linux-m68k•org>,
kvm-ppc@vger•kernel.org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df}
Date: Wed, 25 Aug 2010 11:34:12 +1000 [thread overview]
Message-ID: <10192.1282700052@neuling.org> (raw)
In-Reply-To: <1282699836.22370.566.camel@pasglop>
In message <1282699836.22370.566.camel@pasglop> you wrote:
> On Tue, 2010-08-24 at 15:15 +1000, Michael Neuling wrote:
> > > > Do some 32 bit processors need this?
> > > >
> > > > In 32 bit before the merge, we use to have code that did:
> > > >
> > > > #if defined(CONFIG_4xx) || defined(CONFIG_E500)
> > > > #define cvt_fd without save/restore fpscr
> > > > #else
> > > > #define cvt_fd with save/restore fpscr
> > > > #end if
> > > >
> > > > Kumar; does this ring any bells?
> > >
> > > I don't see anything in the various 440 docs I have at hand that would
> > > hint at lfd/stfs adffecting FPSCR.
> >
> > The way the ifdefs are, it's the other way around. 4xx procs don't need
> > to save/restore fpscr and others do.
>
> Right, my bad. In any case, Paulus reckons it's all his mistake and we
> really never need to save/restore fpscr.
ACK :-P
Mikey
next prev parent reply other threads:[~2010-08-25 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 21:43 [PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df} Andreas Schwab
2010-08-23 0:23 ` Michael Neuling
2010-08-24 5:11 ` Benjamin Herrenschmidt
2010-08-24 5:15 ` Michael Neuling
2010-08-24 5:39 ` Benjamin Herrenschmidt
2010-08-25 1:30 ` Benjamin Herrenschmidt
2010-08-25 1:34 ` Michael Neuling [this message]
2010-08-24 5:47 ` Kumar Gala
2010-08-24 5:51 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10192.1282700052@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox