From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Michael Schmitz <schmitz@zirkon•biophys.uni-duesseldorf.de>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>,
"debian-powerpc@lists•debian.org"
<debian-powerpc@lists•debian.org>
Subject: Re: TEST: Sleep patch #4
Date: Wed, 24 Nov 2004 10:27:03 +1100 [thread overview]
Message-ID: <1101252423.24531.23.camel@gaston> (raw)
In-Reply-To: <Pine.LNX.4.44.0411231224150.7434-100000@zirkon.biophys.uni-duesseldorf.de>
> Looking at radeon_base.c:radeon_screen_blank() (line 1045) we have:
>
> val &= ~(LVDS_BL_MOD_EN);
> udelay(100);
> val &= ~(LVDS_ON | LVDS_EN);
> OUTREG(LVDS_GEN_CNTL, val);
>
>
> Is there an OUTREG(LVDS_GEN_CNTL, val); missing before the udelay(100) ??
>
> That's in the panel blank code, not the unblank code though. Doesn't seem
> to hurt to put the OUTREG in.
won't hurt, dunno if it will help tho... could also be a different
issue, like the spread spectrum PLL not locking properly or something
like that ... I don't really know.
Ben.
next prev parent reply other threads:[~2004-11-23 23:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 6:56 TEST: Sleep suppport for iBook G4 & Aluminium PowerBooks (ATI based) Benjamin Herrenschmidt
2004-11-19 8:50 ` David Woodhouse
2004-11-19 10:33 ` Benjamin Herrenschmidt
2004-11-19 11:06 ` Gabriel Paubert
2004-11-19 22:14 ` Benjamin Herrenschmidt
2004-11-19 19:02 ` Olof Johansson
[not found] ` <1100852423.3855.2.camel@gaston>
2004-11-21 0:01 ` Benjamin Herrenschmidt
2004-11-21 3:00 ` Armando Di Cianno
2004-11-21 7:11 ` Benjamin Herrenschmidt
2004-11-21 17:37 ` Olof Johansson
2004-11-21 21:36 ` Benjamin Herrenschmidt
2004-11-22 8:25 ` David Woodhouse
2004-11-22 0:32 ` TEST: Sleep patch #4 Benjamin Herrenschmidt
2004-11-22 3:12 ` Armando Di Cianno
2004-11-22 13:29 ` Sean Neakums
2004-11-22 16:38 ` Keith Conger
2004-11-22 16:58 ` Keith Conger
2004-11-22 21:48 ` Benjamin Herrenschmidt
2004-11-22 18:36 ` Sean Neakums
2004-11-22 21:52 ` Benjamin Herrenschmidt
2004-11-23 8:27 ` Sean Neakums
2004-11-23 23:25 ` Benjamin Herrenschmidt
2004-11-23 7:58 ` Guido Guenther
2004-11-23 8:40 ` Sean Neakums
2004-11-22 21:13 ` Michel Dänzer
2004-11-22 21:48 ` Benjamin Herrenschmidt
2004-11-22 17:04 ` Michael Schmitz
2004-11-22 21:50 ` Benjamin Herrenschmidt
2004-11-23 8:05 ` Michael Schmitz
2004-11-23 12:28 ` Michael Schmitz
2004-11-23 23:27 ` Benjamin Herrenschmidt [this message]
2004-11-23 1:40 ` Chris Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101252423.24531.23.camel@gaston \
--to=benh@kernel$(echo .)crashing.org \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=schmitz@zirkon$(echo .)biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox