From: Jaap-Jan Boor <jjboor@aimsys•nl>
To: Per Hallsmark <per.hallsmark@t2data•se>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: Question about cpm reset on 8xx
Date: Thu, 03 Feb 2005 15:53:56 +0100 [thread overview]
Message-ID: <1107442436.32038.30.camel@linpc003.aimsys.nl> (raw)
In-Reply-To: <41FFBC75@webmail>
On Thu, 2005-02-03 at 15:29, Per Hallsmark wrote:
> Hi all,
>
> Working with a board using hdlc over SCC channel (852T) and kernel 2.4.21,
> in the cpm reset code in arch/ppc/8xx_io/commproc.c it's like:
>
> void
> m8xx_cpm_reset()
> {
> volatile immap_t *imp;
> volatile cpm8xx_t *commproc;
> pte_t *pte;
>
>
> imp = (immap_t *)IMAP_ADDR;
> commproc = (cpm8xx_t *)&imp->im_cpm;
>
>
> #ifdef CONFIG_UCODE_PATCH
> /* Perform a reset.
> */
> commproc->cp_cpcr = (CPM_CR_RST | CPM_CR_FLG);
>
>
> /* Wait for it.
> */
> while (commproc->cp_cpcr & CPM_CR_FLG);
>
>
> cpm_load_patch(imp);
> #endif
> .......
>
> In our case, CONFIG_UCODE_PATCH is not defined so the commproc is never
> reseted during reboot. Could it be that the #ifdef CONFIG_UCODE_PATCH
> should just be around the cpm_load_patch command?
It seems the author wants to reset the cpm only when microcode
patches are needed.
m8260_cpm_reset() does also not reset the cpm.
I don't know why (e.g. the console is setup after this)
Jaap-Jan
> The CONFIG_UCODE_PATCH seems to point this to be i2c/spi patch, but
> shouldn't a reset go to cpm in anycase?
>
> /Per
>
>
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs•org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
next prev parent reply other threads:[~2005-02-03 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 14:29 Question about cpm reset on 8xx Per Hallsmark
2005-02-03 14:53 ` Jaap-Jan Boor [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-03 15:02 Per Hallsmark
2005-02-03 15:34 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107442436.32038.30.camel@linpc003.aimsys.nl \
--to=jjboor@aimsys$(echo .)nl \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=per.hallsmark@t2data$(echo .)se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox