Subject: Re: mv643xx_eth SA_SHIRQ support patch

From: Benjamin Herrenschmidt <[email-masked]>
Date: Wed, 09 Mar 2005 09:31:26 +1100

> Ok, i should have something working. adding here both sven2-dale.diff which is
> a patch against linux-2.5-mv643xx-enet and sven2.diff which is a patch against
> 2.6.11.
> 
> There is still a bit of cleanup needed in arch/ppc/platforms/mv643xx_eth_pegasos.c 
> especially with regard the headers, and also the proper copyright/attibution
> of it (since dale wrote it and i just pasted it and did the detection stuff
> benh mentioned above.
> 
> I am unsure also about the : 
> 
> @@ -44,6 +44,9 @@
>  #include <asm/pgtable.h>
>  #include <asm/system.h>
>  #include <asm/delay.h>
> +#ifdef PPC_MULTIPLATEFORM
> +#include <mv64x60.h>
> +#endif
>  #include "mv643xx_eth.h"
> 
>  /*
> 
> hunk. dale can you check it ? 

Looks broken...

> Comments are welcome, in particular benh, i guess my detection code will beak
> horribly if there is another host node prior to the marvell one in the OF
> tree, which is not the case currently on pegasos though.

Why are you looking at vid/did ? Isn't there some name string (model,
compatible, whatever) you can use ? Or is your OF too bad to even give
such info ?

You can also iterate after the find_devices() using np->next

Ben.