From: Yuri Tikhonov <yur@emcraft•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org, Detlev Zundel <dzu@denx•de>,
linux-kernel@vger•kernel.org, Ilya Yanok <yanok@emcraft•com>,
Wolfgang Denk <wd@denx•de>
Subject: Re[2]: [PATCH] xsysace: use resource_size_t instead of unsigned long
Date: Fri, 14 Nov 2008 07:57:27 +0300 [thread overview]
Message-ID: <1124454405.20081114075727@emcraft.com> (raw)
In-Reply-To: <20081113212121.e7a9f5fe.sfr@canb.auug.org.au>
=0D=0AHello Stephen,
On Thursday, November 13, 2008 you wrote:
> Hi Yuri,
> On Thu, 13 Nov 2008 11:43:17 +0300 Yuri Tikhonov <yur@emcraft•com> wrote:
>>
>> - dev_dbg(ace->dev, "physaddr=3D0x%lx irq=3D%i\n", ace->physaddr, ac=
e->irq);
>> + dev_dbg(ace->dev, "physaddr=3D0x%llx irq=3D%i\n", (u64)ace->physad=
dr, ace->irq);
> You should cast the physaddr to "unsigned long long" as "u64" is
> "unsigned long" on some architectures. The same is needed in other
> places as well.
Thanks for your comment. We'll fix this.
Regards, Yuri
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
prev parent reply other threads:[~2008-11-14 4:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 8:43 [PATCH] xsysace: use resource_size_t instead of unsigned long Yuri Tikhonov
2008-11-13 10:21 ` Stephen Rothwell
2008-11-14 4:57 ` Yuri Tikhonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124454405.20081114075727@emcraft.com \
--to=yur@emcraft$(echo .)com \
--cc=dzu@denx$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wd@denx$(echo .)de \
--cc=yanok@emcraft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox