From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Olaf Hering <olh@suse•de>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: AC Power handling broken for desktops
Date: Mon, 19 Sep 2005 10:44:22 +1000 [thread overview]
Message-ID: <1127090662.4502.12.camel@gaston> (raw)
In-Reply-To: <20050826113827.GA25134@suse.de>
On Fri, 2005-08-26 at 13:38 +0200, Olaf Hering wrote:
> On Thu, Aug 25, Benjamin Herrenschmidt wrote:
>
> > On Thu, 2005-08-25 at 07:15 +0200, Olaf Hering wrote:
> > > On Thu, Aug 25, Benjamin Herrenschmidt wrote:
> > >
> > > > Not sure :) I don't fully know how to decode those power things in the
> > > > device-tree... There are bits in darwin tho.
> > >
> > > Maybe just check for !PowerBook and force PMU_PWR_AC_PRESENT in this case.
> >
> > Yah, you can check that with pmac_feature, there is a "mobile" flag.
>
> Its not obvious how to get to that flag. Is this patch acceptable?
> No batteries present should mean AC Power == 1.
>
> drivers/macintosh/apm_emu.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
Looks good to me.
Ben
next prev parent reply other threads:[~2005-09-19 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 11:54 AC Power handling broken for desktops Olaf Hering
2005-08-24 22:32 ` Benjamin Herrenschmidt
2005-08-25 4:51 ` Olaf Hering
2005-08-25 5:08 ` Benjamin Herrenschmidt
2005-08-25 5:15 ` Olaf Hering
2005-08-25 5:34 ` Benjamin Herrenschmidt
2005-08-26 11:38 ` Olaf Hering
2005-09-19 0:44 ` Benjamin Herrenschmidt [this message]
2005-10-10 17:08 ` [PATCH] " Olaf Hering
2005-08-25 15:10 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127090662.4502.12.camel@gaston \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=olh@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox