From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Geoff Levand <geoffrey.levand@am•sony.com>
Cc: linuxppc64-dev@ozlabs•org,
"debian-powerpc@lists•debian.org"
<debian-powerpc@lists•debian.org>,
Linux Kernel list <linux-kernel@vger•kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs•org>
Subject: Re: iMac G5: experimental thermal & cpufreq support
Date: Fri, 30 Sep 2005 10:26:59 +1000 [thread overview]
Message-ID: <1128040019.31197.3.camel@gaston> (raw)
In-Reply-To: <433C7882.20000@am.sony.com>
On Thu, 2005-09-29 at 16:28 -0700, Geoff Levand wrote:
> Benjamin Herrenschmidt wrote:
> > The algorithm itself is extracted from darwin. However, it's a rather
> > complex modified version of the PID algorithm, and thus it could use
> > some review to make sure I got everything right.
> >
>
> As we are already in the digital domain, I would think it would be
> more savvy to use a digital controller than try to simulate an
> analog controller... Why don't you abstract the control algorithm
> such that you can plug in others as they are developed.
Because I don't know much about those control algorithms, and all the
calibration data provided by the firmware is in the form of factors for
these algorithms, I wouldn't know how to "unmangle" them to use with
different ones.
Actually, the control algorithms (PID and modified PID) are in a
"helper", so it's fairly easy for the platform module to use whatever it
wants, feel free to submit other algorithms :) But for Apple machines,
I'd rather use what I have calibration data for, unless you can produce
something that works without any...
Ben.
next prev parent reply other threads:[~2005-09-30 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 7:20 iMac G5: experimental thermal & cpufreq support Benjamin Herrenschmidt
2005-09-29 8:40 ` Benjamin Herrenschmidt
2005-09-30 7:12 ` Benjamin Herrenschmidt
2005-09-29 23:28 ` Geoff Levand
2005-09-30 0:26 ` Benjamin Herrenschmidt [this message]
2005-09-30 1:00 ` Dean Hamstead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128040019.31197.3.camel@gaston \
--to=benh@kernel$(echo .)crashing.org \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc64-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox