From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs•org>,
debian-powerpc <debian-powerpc@lists•debian.org>
Subject: Re: [PATCH] via-pmu: report powerbutton as proper input event
Date: Mon, 01 May 2006 16:58:36 +1000 [thread overview]
Message-ID: <1146466716.30710.39.camel@localhost.localdomain> (raw)
In-Reply-To: <1146251713.5019.4.camel@localhost>
On Fri, 2006-04-28 at 21:15 +0200, Johannes Berg wrote:
> This patch adds an input device for the power button so that userspace gets
> notified about the user pressing it via the standard input layer.
Looks interesting. Waht about other buttons/events the PMU can report ?
> +#endif /* __VIA_PMU_EVENT_H */
> --- linux-2.6.orig/include/linux/input.h 2006-04-28 20:00:37.417288704 +0200
> +++ linux-2.6/include/linux/input.h 2006-04-28 20:00:48.157288704 +0200
> @@ -658,6 +658,7 @@ struct input_absinfo {
> #define BUS_I2C 0x18
> #define BUS_HOST 0x19
> #define BUS_GSC 0x1A
> +#define BUS_PMU 0x20
Magic numbers... BAD BAD BAD ... Somebody needs to LART the input layer
people.
> @@ -2915,6 +2921,10 @@ static int __init init_pmu_led(void)
> if (pmu_led_init()) {
> printk(KERN_WARNING "via-pmu: LED failed to init\n");
> }
> +
> + /* only on keylargo can the power button be on the pmu ... */
> + if (pmu_event_init())
> + printk(KERN_WARNING "via-pmu: couldn't add event device");
> }
>
> return 0;
Do we need these here ? Why not an initcall self-contained in each
file ?
Ben.
next prev parent reply other threads:[~2006-05-01 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 19:15 [PATCH] via-pmu: report powerbutton as proper input event Johannes Berg
2006-05-01 6:58 ` Benjamin Herrenschmidt [this message]
2006-05-01 8:56 ` Johannes Berg
2006-05-01 9:09 ` Benjamin Herrenschmidt
2006-05-01 9:21 ` Johannes Berg
2006-05-01 9:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146466716.30710.39.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=debian-powerpc@lists$(echo .)debian.org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox