Subject: Re: [PATCH] via-pmu: report powerbutton as proper input event

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 01 May 2006 19:09:26 +1000

On Mon, 2006-05-01 at 10:56 +0200, Johannes Berg wrote:
> On Mon, 2006-05-01 at 16:58 +1000, Benjamin Herrenschmidt wrote:
> > On Fri, 2006-04-28 at 21:15 +0200, Johannes Berg wrote:
> > > This patch adds an input device for the power button so that userspace gets
> > > notified about the user pressing it via the standard input layer.
> > 
> > Looks interesting. Waht about other buttons/events the PMU can report ?
> 
> What else does it report? As far as I know it doesn't have anything
> else, at least on my system.

Depends on the machine... earlier ones have the backlight there or
volume control.. then LID close could be an event too...

> > > +#define BUS_PMU			0x20
> > 
> > Magic numbers... BAD BAD BAD ... Somebody needs to LART the input layer
> > people.
> 
> It's not really a "magic" number since it doesn't really carry any
> information, or would you like string identifiers in each device
> descriptor? An enum would be just the same, in fact, the definition
> could be rewritten as an enum :)
> 
> > Do we need these here ? Why not an initcall self-contained in each
> > file ?
> 
> No heh, good point.
> 
> Thanks,
> johannes