From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: "Rafael J. Wysocki" <rjw@sisk•pl>,
linuxppc-dev list <linuxppc-dev@ozlabs•org>,
linux-pm@lists•osdl.org
Subject: Re: [PATCH] fix windfarm core thread wrt. signal handling
Date: Wed, 28 Jun 2006 08:07:06 +1000 [thread overview]
Message-ID: <1151446026.2350.76.camel@localhost.localdomain> (raw)
In-Reply-To: <1151432266.4289.6.camel@localhost>
On Tue, 2006-06-27 at 20:17 +0200, Johannes Berg wrote:
> This patch removes the signal_pending() from the windfarm core thread
> loop as it isn't necessary and messes up when there actually *is* a
> signal pending because we should enter the freezer.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions•net>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> diff --git a/drivers/macintosh/windfarm_core.c b/drivers/macintosh/windfarm_core.c
> index ab3faa7..c05a838 100644
> --- a/drivers/macintosh/windfarm_core.c
> +++ b/drivers/macintosh/windfarm_core.c
> @@ -116,12 +116,6 @@ static int wf_thread_func(void *data)
> delay = next - jiffies;
> if (delay <= HZ)
> schedule_timeout_interruptible(delay);
> -
> - /* there should be no signal, but oh well */
> - if (signal_pending(current)) {
> - printk(KERN_WARNING "windfarm: thread got sigl !\n");
> - break;
> - }
> }
>
> DBG("wf: thread stopped\n");
>
next prev parent reply other threads:[~2006-06-27 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 23:51 windfarm got signal Johannes Berg
2006-06-22 6:02 ` Benjamin Herrenschmidt
2006-06-22 11:03 ` [linux-pm] " Rafael J. Wysocki
2006-06-22 11:13 ` Johannes Berg
2006-06-22 11:34 ` Johannes Berg
2006-06-22 12:33 ` Nigel Cunningham
2006-06-27 7:44 ` Benjamin Herrenschmidt
2006-06-27 18:17 ` [PATCH] fix windfarm core thread wrt. signal handling Johannes Berg
2006-06-27 22:07 ` Benjamin Herrenschmidt [this message]
2006-06-22 13:12 ` [linux-pm] windfarm got signal Pavel Machek
2006-06-23 10:05 ` [PATCH] windfarm: proper try_to_freeze / signal_pending handling Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151446026.2350.76.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-pm@lists$(echo .)osdl.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=rjw@sisk$(echo .)pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox