On Fri, 2006-07-07 at 18:56 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2006-07-07 at 10:49 +0200, Johannes Berg wrote: > > On Fri, 2006-07-07 at 17:47 +1000, Benjamin Herrenschmidt wrote: > > > Also, we should try > > > (if not already the case) to cache our clock/i2s state so that > > > subsequent prepare() don't try to change things that are already ok. > > > > I do that, the function reads the dws and sfr registers and exits early > > if they match. > > Ok. Be careful that I've removed the initial init of TAS thinking we > always get to clock restart to do it in prepare()... might need to be > put back. Oh yes, we do, wonder why it even worked then since most of the time we'll be using whatever the firmware does (44.1KHz,16bit). johannes