From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Geoff Levand <geoffrey.levand@am•sony.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: powerpc virq: new routine virq_to_hw
Date: Wed, 30 Aug 2006 08:36:12 +1000 [thread overview]
Message-ID: <1156890972.8433.576.camel@localhost.localdomain> (raw)
In-Reply-To: <44F305AA.5020101@am.sony.com>
On Mon, 2006-08-28 at 08:03 -0700, Geoff Levand wrote:
> Benjamin Herrenschmidt wrote:
> > I'd much prefer:
> >
> > static inline irq_hw_number_t virq_to_hw (unsigned int virq)
> > {
> > return irq_map[virq].hwirq;
> > }
>
> Here is an updated version.
>
> -Geoff
>
>
> This adds an accessor routine virq_to_hw() to the
> virq routines which hides the implementation details
> of the virq to hwirq map.
>
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
> Index: cell--common--4/include/asm-powerpc/irq.h
> ===================================================================
> --- cell--common--4.orig/include/asm-powerpc/irq.h
> +++ cell--common--4/include/asm-powerpc/irq.h
> @@ -136,6 +136,10 @@
>
> extern struct irq_map_entry irq_map[NR_IRQS];
>
> +static inline irq_hw_number_t virq_to_hw(unsigned int virq)
> +{
> + return irq_map[virq].hwirq;
> +}
>
> /**
> * irq_alloc_host - Allocate a new irq_host data structure
prev parent reply other threads:[~2006-08-29 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 23:02 powerpc virq: new routine virq_to_hw Geoff Levand
2006-08-28 1:22 ` Benjamin Herrenschmidt
2006-08-28 7:16 ` Segher Boessenkool
2006-08-28 15:03 ` Geoff Levand
2006-08-29 22:36 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156890972.8433.576.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox