From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Jon Loeliger <jdl@freescale•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] Add new, missing argument to of_irq_map_raw().
Date: Sat, 02 Sep 2006 13:29:06 +1000 [thread overview]
Message-ID: <1157167746.4446.23.camel@localhost.localdomain> (raw)
In-Reply-To: <E1GJAlk-00053S-3U@jdl.com>
On Fri, 2006-09-01 at 10:17 -0500, Jon Loeliger wrote:
> Ben speaks; we follow.
Ooops, sorry. I din't grep around thinking nobody would need to use that
low level function but it looks like you do have a good reason to do
so.
Ben.
> Signed-off-by: Jon Loeliger <jdl@freescale•com>
> ---
>
> Paul,
>
> This patch is needed in the 2.6.18 release for 86xx.
> Ben's recent changes to of_irq_map_raw() missed one caller.
> This patch cleans that up.
>
> Thanks,
> jdl
>
>
> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
> index 4a33d95..cdaf668 100644
> --- a/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
> +++ b/arch/powerpc/platforms/86xx/mpc86xx_hpcn.c
> @@ -154,7 +154,7 @@ get_pci_irq_from_of(struct pci_controlle
>
> laddr[0] = (hose->first_busno << 16) | (PCI_DEVFN(slot, 0) << 8);
> laddr[1] = laddr[2] = 0;
> - of_irq_map_raw(hosenode, &pin, laddr, &oirq);
> + of_irq_map_raw(hosenode, &pin, 1, laddr, &oirq);
> DBG("mpc86xx_hpcn: pci irq addr %x, slot %d, pin %d, irq %d\n",
> laddr[0], slot, pin, oirq.specifier[0]);
> return oirq.specifier[0];
prev parent reply other threads:[~2006-09-02 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 15:17 [PATCH] Add new, missing argument to of_irq_map_raw() Jon Loeliger
2006-09-02 3:29 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157167746.4446.23.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=jdl@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox