Subject: Re: [Cbe-oss-dev] [PATCH] cell: use ppc_md->power_save instead of cbe_idle_loop

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 23 Oct 2006 20:16:27 +1000

> +	/*
> +	 * We need to call cbe_enable_pause_zero on each CPU
> +	 * before first entering power_save(). The most convenient
> +	 * place for this is ppc_md->idle, because that is called
> +	 * right before entering the idle loop.
> +	 */
> +	ppc_md.idle_loop = cbe_enable_pause_zero;

I disagree here... this should be done in setup_cpu() for non-boot CPUs,
and sometime in setup_arch for the boot CPU. 

Another option is to have the pm_control bit done once for all CPUs at
boot in setup_arch() or such, and the TSC_CELL SPR bit done
unconditionally in powersave...

Ben.