From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Michael Ellerman <michael@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [PATCH] Make irq_dispose_mapping(NO_IRQ) a nop
Date: Tue, 24 Oct 2006 13:52:17 +1000 [thread overview]
Message-ID: <1161661937.10524.549.camel@localhost.localdomain> (raw)
In-Reply-To: <20061024033735.AF71B67B6D@ozlabs.org>
On Tue, 2006-10-24 at 13:37 +1000, Michael Ellerman wrote:
> It makes for a friendlier API if irq_dispose_mapping(NO_IRQ) is a
> nop, rather than triggering a WARN_ON.
>
> Signed-off-by: Michael Ellerman <michael@ellerman•id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
>
> arch/powerpc/kernel/irq.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Index: git/arch/powerpc/kernel/irq.c
> ===================================================================
> --- git.orig/arch/powerpc/kernel/irq.c
> +++ git/arch/powerpc/kernel/irq.c
> @@ -626,10 +626,14 @@ EXPORT_SYMBOL_GPL(irq_of_parse_and_map);
>
> void irq_dispose_mapping(unsigned int virq)
> {
> - struct irq_host *host = irq_map[virq].host;
> + struct irq_host *host;
> irq_hw_number_t hwirq;
> unsigned long flags;
>
> + if (virq == NO_IRQ)
> + return;
> +
> + host = irq_map[virq].host;
> WARN_ON (host == NULL);
> if (host == NULL)
> return;
prev parent reply other threads:[~2006-10-24 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 3:37 [PATCH] Make irq_dispose_mapping(NO_IRQ) a nop Michael Ellerman
2006-10-24 3:52 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161661937.10524.549.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox