From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: linuxppc-dev <Linuxppc-dev@ozlabs•org>
Subject: 83xx usage of pci_fixup_irq
Date: Thu, 26 Oct 2006 14:34:25 +1000 [thread overview]
Message-ID: <1161837265.5299.11.camel@localhost.localdomain> (raw)
I'd like to remove on ppc32 those 2 members of ppc_md:
unsigned char (*pci_swizzle)(struct pci_dev *, unsigned char *);
int (*pci_map_irq)(struct pci_dev *, unsigned char, unsigned char);
They are used by only those 2 platforms:
arch/powerpc/platforms/83xx/mpc832x_mds.c:
and
arch/powerpc/platforms/83xx/mpc8360e_pb.c:
They shouldn't be necessary however with the prom_parse.c code and using
standard of_irq_map_pci() (or pci_read_irq_line() which uses it).
So is there any special reason I can't just remove these ?
(I'm also adding a common 32/64 bits pci_irq_fixup for platforms that
really need a fixup and making pci_read_irq_line() the default).
If we ever need some non-standard swizzle, then I might re-introduce a
swizzle callback in here (but common 32/64 bits this time) that is used
by of_irq_map_pci().
Ben.
reply other threads:[~2006-10-26 4:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161837265.5299.11.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox