Subject: Re: [PATCH/RFC] powerpc: Create PCI busses from of_platform

From: Benjamin Herrenschmidt <[email-masked]>
Date: Sun, 05 Nov 2006 08:53:56 +1100

On Sat, 2006-11-04 at 16:40 +0100, Segher Boessenkool wrote:
> > +static struct of_device_id of_pci_phb_ids[] = {
> > +	{ .type = "pci", },
> > +	{ .type = "pcix", },
> > +	{ .type = "pcie", },
> > +	{ .type = "pciex", },
> > +	{ .type = "ht", },
> > +	{}
> > +};
> > +
> > +static struct of_platform_driver of_pci_phb_driver = {
> > +       .name = "of-pci",
> > +       .match_table = of_pci_phb_ids,
> > +       .probe = of_pci_phb_probe,
> > +       .driver = {
> > +	       .multithread_probe = 1,
> > +       },
> > +};
> 
> Shouldn't you also/only check for compatible=pci?  Or maybe
> that would give too much fallout from all the broken device
> trees out there?

We can add things when we need them. This mecanism is to be used by
platforms who register of_device's for the PHBs. Currently, this will
only happen with Cell, so I only need to deal with what's there (I could
even remove 'ht' from the list :-)

As more platforms want to use it, they can fine-tune the list and probe
function.

Ben.