public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Sergei Shtylyov <sshtylyov@ru•mvista.com>
Cc: linuxppc-dev@ozlabs•org, tglx@linutronix•de, greg.weeks@timesys•com
Subject: Re: [PATCH] PowerPC: clockevents and HRT support
Date: Wed, 08 Nov 2006 09:36:37 +1100	[thread overview]
Message-ID: <1162938997.28571.534.camel@localhost.localdomain> (raw)
In-Reply-To: <200611080005.08633.sshtylyov@ru.mvista.com>


> +#ifdef CONFIG_PPC_MULTIPLATFORM
> +	/*
> +	 * We must write a positive value to the decrementer to clear
> +	 * the interrupt on the IBM 970 CPU series.  In periodic mode,
> +	 * this happens when the decrementer gets reloaded later, but
> +	 * in one-shot mode, we have to do it here since an event handler
> +	 * may skip loading the new value...
> +	 */
> +	if (per_cpu(decrementers, cpu).mode != CLOCK_EVT_PERIODIC)
> +		set_dec(DECREMENTER_MAX);
> +#endif

PPC_MULTIPLATFORM is going away soon (or will be set for all CPU types
in arch/powerpc). Just make up a macro at the top of the file around the
lines of

#if defined(CONFIG_40x) || defined(CONFIG_BOOKE)
#define PPC_BOOKE_DECREMENTER
#endif

And use #if(n)def PPC_BOOKE_DECREMENTER in the rest of the code.

Also, what's the problem with ppc64 deterministic accounting that you
can't fix it ?

Ben.

  reply	other threads:[~2006-11-07 22:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-07 21:05 [PATCH] PowerPC: clockevents and HRT support Sergei Shtylyov
2006-11-07 22:36 ` Benjamin Herrenschmidt [this message]
2006-11-07 22:44   ` Sergei Shtylyov
2006-11-07 23:04     ` Benjamin Herrenschmidt
2006-11-07 23:21       ` Sergei Shtylyov
2006-11-08  0:18         ` Benjamin Herrenschmidt
2006-11-08  1:19           ` Mark A. Greer
2006-11-08  2:06             ` Benjamin Herrenschmidt
2006-11-08 14:14               ` Sergei Shtylyov
2006-11-08  2:00     ` Paul Mackerras
2006-11-08 14:21       ` Sergei Shtylyov
2006-11-10  8:32         ` Paul Mackerras
2006-11-10 14:08           ` Sergei Shtylyov
2006-11-10 23:52             ` Paul Mackerras
2006-11-12 18:30               ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1162938997.28571.534.camel@localhost.localdomain \
    --to=benh@kernel$(echo .)crashing.org \
    --cc=greg.weeks@timesys$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=sshtylyov@ru$(echo .)mvista.com \
    --cc=tglx@linutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox