Subject: Re: [PATCH]: PowerPC: make sure the rtas stop-self token is defined.

From: Michael Ellerman <[email-masked]>
Date: Tue, 14 Nov 2006 12:17:44 +1100

On Mon, 2006-11-13 at 12:05 -0600, Linas Vepstas wrote:
> On Mon, Nov 13, 2006 at 12:21:04AM -0600, jschopp wrote:
> > >I can only find one caller? Is it called via a #define or something?
> 
> Right. I was looking at pSeries_mach_cpu_die(), which is called
> as md.cpu_die from many places.
> 
> > >Wouldn't it be preferable to just change rtas.h like so:
> > >
> > >#ifdef CONFIG_HOTPLUG_CPU
> > >extern void rtas_stop_self(void);
> > >#else
> > >static inline void rtas_stop_self(void) { }
> > >#endif
> 
> Well, the problem is that this would just pass the BUG() to 
> the next level, in pSeries_mach_cpu_die():
> 
> static void pSeries_mach_cpu_die(void)
> {
>    local_irq_disable();
>    idle_task_exit();
>    xics_teardown_cpu(0);
>    rtas_stop_self();
>    /* Should never get here... */
>    BUG();
>    for(;;);
> }
> 
> so does that mean that CONFIG_HOTPLUG_CPU should also be used to 
> stop the complation of pSeries_mach_cpu_die() ? 

Yes. And its connection to ppc_md.cpu_die.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person