Subject: Re: [PATCH] Powerpc: Make pci_read_irq_line the default: on mpc7448hpc2 board

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 14 Nov 2006 16:45:52 +1100

Good. Same comments as with Vitaly though :-)

> +static void pci_irq_host_unmap(struct irq_host *h, unsigned int virq)
> +{
> +	/* Make sure irq is masked in hardware */
> +	
> +	tsi108_pci_int_mask(virq);
> +
> +	/* remove chip and handler */
> +	set_irq_chip_and_handler(virq, NULL, NULL);
> +
> +	/* Make sure it's completed */
> +	synchronize_irq(virq);
> +}

You probably don't need that... the generic code should do the above
just fine unless something is wrong in which case we should fix it.

> +static int pci_irq_host_match(struct irq_host *h, struct device_node *node)
> +{
> +	return pci_irq_node == NULL || pci_irq_node == node;
> +}

You probably don't want the NULL test here.

Cheers,
Ben.