Subject: Re: [PATCH 9/16] Supporting of PCI bus for Celleb

From: Benjamin Herrenschmidt <[email-masked]>
Date: Thu, 16 Nov 2006 10:40:43 +1100

> 
> This look broken to me.  Busses that do not support config space
> cycles shouldn't be reported to the PCI layer at all.
> 
> > +struct pci_ops celleb_fake_pci_ops = {
> > +	celleb_fake_pci_read_config,
> > +	celleb_fake_pci_write_config
> > +};
> 
> What are these fake ops for?  If you don't have a real PCI
> bus you shouldn't emulate it but use a vio-style bus insted.

That was discussed with them earlier and we decided that for now
it was ok to do it that way. They are doing like us :-) Except that on
the blade, the PCI is "emulated" for the spider by RTAS and in their
case, they do it explicitely.

With the kernel being able to build the PCI tree from the device-tree,
this isn't really a problem, and that gives them spidernet and usb for
"free" as they already know how to probe PCI devices.

Ben.