From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Ishizaki Kou <kou.ishizaki@toshiba•co.jp>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 15/16] TLB insersion for Celleb
Date: Thu, 16 Nov 2006 10:57:40 +1100 [thread overview]
Message-ID: <1163635060.5940.295.camel@localhost.localdomain> (raw)
In-Reply-To: <200611151000.kAFA0Fxs012318@toshiba.co.jp>
On Wed, 2006-11-15 at 19:00 +0900, Ishizaki Kou wrote:
> This patch changes handling return value of ppc_md.hpte_insert() to
> the same way as __hash_page_*().
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba•co.jp>
Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> ---
>
> Index: linux-2.6.19/arch/powerpc/mm/hugetlbpage.c
> diff -u linux-2.6.19/arch/powerpc/mm/hugetlbpage.c:1.1.1.1 linux-2.6.19/arch/powerpc/mm/hugetlbpage.c:1.2
> --- linux-2.6.19/arch/powerpc/mm/hugetlbpage.c:1.1.1.1 Fri Oct 6 10:40:06 2006
> +++ linux-2.6.19/arch/powerpc/mm/hugetlbpage.c Wed Oct 11 20:45:10 2006
> @@ -1008,7 +1008,6 @@
>
> /* Primary is full, try the secondary */
> if (unlikely(slot == -1)) {
> - new_pte |= _PAGE_F_SECOND;
> hpte_group = ((~hash & htab_hash_mask) *
> HPTES_PER_GROUP) & ~0x7UL;
> slot = ppc_md.hpte_insert(hpte_group, va, pa, rflags,
> @@ -1027,7 +1026,7 @@
> if (unlikely(slot == -2))
> panic("hash_huge_page: pte_insert failed\n");
>
> - new_pte |= (slot << 12) & _PAGE_F_GIX;
> + new_pte |= (slot << 12) & (_PAGE_F_SECOND | _PAGE_F_GIX);
> }
>
> /*
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs•org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2006-11-15 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 10:00 [PATCH 15/16] TLB insersion for Celleb Ishizaki Kou
2006-11-15 23:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163635060.5940.295.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=kou.ishizaki@toshiba$(echo .)co.jp \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox