Subject: Re: [PATCH]: wrap cpu_die() with CONFIG_HOTPLUG_CPU

From: Michael Ellerman <[email-masked]>
Date: Fri, 17 Nov 2006 09:34:57 +1100

On Thu, 2006-11-16 at 15:41 -0600, Linas Vepstas wrote:
> Paul,
> 
> Please apply; this is an updated patch per Michael Ellerman,
> below.
> 
> --linas
> 
> On Thu, Nov 16, 2006 at 10:58:45AM +1100, Michael Ellerman wrote:
> > 
> > Thanks for writing it up as a patch. Couple of nit-picky comments below:
> 
> Nitpicking's OK.
> 
> >   +#else
> >    #define pSeries_mach_cpu_die NULL
> > > +#endif
> > 
> > Not sure if that's a good idea, it would save the #ifdef around the
> > structure assignment below.
> 
> Hmm. Personally, I find the #ifdef in the structure to be more 
> readable, in the sense that one is less likely to mis-read what
> the code is actually doing, when on is skimming quickly. But,
> not worth arguing over. The patch below incorporates your 
> suggestions.

Yeah, it's a trade off, I'm not 100% sure it's a good idea - but we'll
see what others think :)

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person