From: Michael Ellerman <michael@ellerman•id.au>
To: Linas Vepstas <linas@austin•ibm.com>
Cc: akpm@osdl•org, Greg KH <greg@kroah•com>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Alan Cox <alan@redhat•com>
Subject: Re: [PATCH]: HVCS char driver janitoring: fix compile warnings
Date: Fri, 17 Nov 2006 09:35:36 +1100 [thread overview]
Message-ID: <1163716536.16815.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20061116203946.GA23600@austin.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
On Thu, 2006-11-16 at 14:39 -0600, Linas Vepstas wrote:
> On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote:
> > On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote:
> > >
> > > This is a non-urgent patch.
> > >
> > > I can't figure out who the upstream maintainer for char drivers
> > > is supposed to be. Can this patch be applied?
> > >
> > > --linas
> > >
> > > This patch removes an pair of irritating compiler warnings:
> > >
> > > drivers/char/hvcs.c:1605: warning: ignoring return value of
> > > sysfs_create_group declared with attribute warn_unused_result
> > > drivers/char/hvcs.c:1639: warning: ignoring return value of
> > > driver_create_file declared with attribute warn_unused_result
> > >
> > > Doing this required moving a big block of code from the bottom
> > > of the file to the top, so as to avoid the need for (irritating)
> > > forward declarations.
> >
> > Can you do the move and the fix as two patches? It's very hard to review
> > in its current form.
>
> Sorry, coming shortly. -- linas
Thanks, new patches look good.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-11-16 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 21:26 [PATCH]: HVCS char driver janitoring: fix compile warnings Linas Vepstas
2006-11-16 0:03 ` Michael Ellerman
2006-11-16 20:39 ` Linas Vepstas
2006-11-16 22:35 ` Michael Ellerman [this message]
2006-11-17 0:55 ` Linas Vepstas
2006-11-17 1:11 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163716536.16815.5.camel@localhost.localdomain \
--to=michael@ellerman$(echo .)id.au \
--cc=akpm@osdl$(echo .)org \
--cc=alan@redhat$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linas@austin$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox