Subject: Re: [POWERPC] fix cell pmu initialisation

From: Benjamin Herrenschmidt <[email-masked]>
Date: Wed, 06 Dec 2006 09:31:15 +1100

On Wed, 2006-12-06 at 09:21 +1100, Michael Ellerman wrote:
> On Wed, 2006-12-06 at 07:07 +1100, Benjamin Herrenschmidt wrote:
> > > 1. export a method from cbe_regs.c to find out whether the pmd 
> > >    regs are available and test that in cbe_init_pm_irq().
> > > 2. take you patch as is, with a comment hinting to fix it up
> > >    when needed.
> > > 3. change cbe_init_pm_irq to be called explicitly from cbe_regs_init(),
> > >    which already scans the device tree correctly.
> > 
> > cbe_regs_init() is called from setup_arch(), which is _very_ early.
> > 
> > cbe_init_pm_irq() must be called much later as it requests irqs.
> > 
> > Right now, we should stick to the machine_is() solution. We'll look into
> > doing something better eventually when the need occurs.
> 
> 4. Add a FIRMWARE_FEATURE for it.

Not sure yet ... it's not really a firmware feature... Let's keep the
machine_is(cell) for now.

Ben.