Subject: Re: [PATCH 12/15] powerpc: Do not use op_model_cell under LPAR

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 12 Dec 2006 15:53:46 +1100

On Tue, 2006-12-12 at 15:13 +1100, Michael Ellerman wrote:
> On Tue, 2006-12-12 at 13:02 +0900, Ishizaki Kou wrote:
> > op_model_cell supports native Cell processor. Under LPAR environment,
> > it cannot work.
> > 
> > Signed-off-by: Kou Ishizaki <kou.ishizaki.co.jp>
> > ---
> > 
> > Index: linux-powerpc-git/arch/powerpc/oprofile/common.c
> > diff -u linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1 linux-powerpc-git/arch/powerpc/oprofile/common.c:1.2
> > --- linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1	Wed Dec  6 08:25:43 2006
> > +++ linux-powerpc-git/arch/powerpc/oprofile/common.c	Wed Dec  6 08:43:15 2006
> > @@ -149,6 +149,8 @@
> >  #ifdef CONFIG_PPC64
> >  #ifdef CONFIG_PPC_CELL_NATIVE
> >  		case PPC_OPROFILE_CELL:
> > +			if (firmware_has_feature(FW_FEATURE_LPAR))
> > +				return -ENODEV;
> >  			model = &op_model_cell;
> >  			break;
> >  #endif
> 
> Is FW_FEATURE_LPAR is the right switch to use here, I'm not sure.

For now, it probably is as none of the LPAR env. for cell work with that
op_model.

Ben.