From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Andrew Morton <akpm@osdl•org>
Cc: Cornelia Huck <cornelia.huck@de•ibm.com>,
linuxppc-dev@ozlabs•org,
Mariusz Kozlowski <m.kozlowski@tuxland•pl>,
linux-kernel@vger•kernel.org, Greg KH <greg@kroah•com>
Subject: Re: 2.6.20-rc3-mm1
Date: Sat, 06 Jan 2007 08:24:44 +1100 [thread overview]
Message-ID: <1168032284.22458.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20070105131516.bd9d8f45.akpm@osdl.org>
On Fri, 2007-01-05 at 13:15 -0800, Andrew Morton wrote:
> On Sat, 06 Jan 2007 07:55:36 +1100
> Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> > On Fri, 2007-01-05 at 17:23 +0100, Mariusz Kozlowski wrote:
> > > Hello,
> > >
> > > Doesn't build on my iMac G3 based garage jukebox ;-)
> > >
> > > arch/powerpc/kernel/of_platform.c:479: error: unknown field 'multithread_probe' specified in initializer
> > > arch/powerpc/kernel/of_platform.c:479: warning: initialization makes pointer from integer without a cast
> > > make[1]: *** [arch/powerpc/kernel/of_platform.o] Blad 1
> > > make: *** [arch/powerpc/kernel] Blad 2
> > >
> > > I guess someone who knows multithread code should take a look at it.
> >
> > Hrm. struct driver -> multithread_probe is gone in -mm ?
> >
>
> yeah, it moved into struct bus_type.
>
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/broken-out/driver-core-per-subsystem-multithreaded-probing.patch
Hrm. I disagree with this change. I have a few cases where drivers
actually want to explicitely do that. I suppose they can always fire off
a thread themselves from probe() but I don't see the reason to move it
to the bus type...
Easy enough for the bus type to force it if it wants.
Ben.
next prev parent reply other threads:[~2007-01-05 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070104220200.ae4e9a46.akpm@osdl.org>
2007-01-05 16:23 ` 2.6.20-rc3-mm1 Mariusz Kozlowski
2007-01-05 18:45 ` 2.6.20-rc3-mm1 Tim Schmielau
2007-01-08 12:36 ` 2.6.20-rc3-mm1 Mariusz Kozlowski
2007-01-05 20:55 ` 2.6.20-rc3-mm1 Benjamin Herrenschmidt
2007-01-05 21:15 ` 2.6.20-rc3-mm1 Andrew Morton
2007-01-05 21:24 ` Benjamin Herrenschmidt [this message]
2007-01-08 19:32 ` 2.6.20-rc3-mm1 Cornelia Huck
2007-01-08 21:19 ` 2.6.20-rc3-mm1 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168032284.22458.33.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=akpm@osdl$(echo .)org \
--cc=cornelia.huck@de$(echo .)ibm.com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=m.kozlowski@tuxland$(echo .)pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox