Subject: Re: [PATCH 4/7] MPIC MSI allocator

From: Will Schmidt <[email-masked]>
Date: Thu, 11 Jan 2007 11:19:41 -0600

On Thu, 2007-11-01 at 16:14 +0100, Segher Boessenkool wrote:
> > +	msi_debug("found U3, guessing msi allocator setup\n");
> > +
> > +	/* Reserve source numbers we know are reserved in the HW */
> > +	for (i = 0;   i < 8;   i++) __mpic_msi_reserve_hwirq(mpic, i);
> > +	for (i = 42;  i < 46;  i++) __mpic_msi_reserve_hwirq(mpic, i);
> > +	for (i = 100; i < 105; i++) __mpic_msi_reserve_hwirq(mpic, i);
> 
> Coding style.  The ranges you reserve are a bit too wide,
> but that is certainly safe.

Can you clarify that comment a bit for me?    Why are they too wide, and
if they are too wide, how are they still safe?   

-Will

> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev