Subject: Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb

From: Will Schmidt <[email-masked]>
Date: Mon, 15 Jan 2007 10:07:56 -0600

On Sat, 2007-13-01 at 23:46 +1100, Anton Blanchard wrote:
> Hi,
> 
> Just a few suggestions.
> 
> > +#define	HCALL_MEDIUM	or 	2,2,2
> 
> Doesnt look like this is used.

seconded.  that #define is identical to HMT_MEDIUM out of ppc_asm.h.  I
notice that HMT_MEDIUM is actually used throughout this patch, so most
of the way there already.

> > +#define	HVSC	.long	0x44000022
> 
> Could you pick this up from the define in include/asm-powerpc instead?

"#include <asm/hvcall.h>" should do it.

> 
> > +#define	LOAD_CONST64(r, const)					\
> > +	lis	r, ((const)>>48)&0xFFFF;			\
> > +	ori	r, r, ((const)>>32)&0xFFFF;			\
> > +	rldicr	r, r, 32, 31;					\
> > +	oris	r, r, ((const)>>16)&0xFFFF;			\
> > +	ori	r, r, ((const)>>0)&0xFFFF
> 
> It doesnt look like this is used either.
> 
> Anton
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev