Subject: Re: [PATCH 13/19] powerpc: Supporting iommu for Celleb

From: Benjamin Herrenschmidt <[email-masked]>
Date: Thu, 18 Jan 2007 11:31:20 +1100

> +static int __init celleb_init_iommu(void)
> +{

This needs a:

	if (!machine_is(celleb))
		return 0;

Since the initcall will always be called wether your platform was
selected at boot or not as long as it's built into the kernel.

> +	celleb_init_direct_mapping();
> +	pci_dma_ops = &dma_direct_ops;
> +	bus_register_notifier(&of_platform_bus_type, &celleb_of_bus_notifier);
> +
> +	return 0;
> +}
> +
> +arch_initcall(celleb_init_iommu);
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev