From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: Geoff Levand <geoffrey.levand@am•sony.com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 8/14] ps3: bind interrupt to cpu
Date: Thu, 25 Jan 2007 14:54:05 +1100 [thread overview]
Message-ID: <1169697245.24996.52.camel@localhost.localdomain> (raw)
In-Reply-To: <45B8188A.5070900@am.sony.com>
> -int ps3_alloc_io_irq(unsigned int interrupt_id, unsigned int *virq);
> +enum ps3_cpu_binding {
> + PS3_BINDING_CPU_0 = 0,
> + PS3_BINDING_CPU_1 = 1,
> + PS3_BINDING_CPU_ANY = 3,
> +};
While this patch might still get in since it actually fixes a problem,
the normal way of expressing interrupt bindings on linux is via a
cpumask. I recommend you do that too and update the affinity mask in
the irq_desc even if you don't provide a set_affinity() callback to
do runtime change just yet (and maybe never due to HV limitations).
Ben.
next prev parent reply other threads:[~2007-01-25 3:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:40 [PATCH 8/14] ps3: bind interrupt to cpu Geoff Levand
2007-01-25 3:54 ` Benjamin Herrenschmidt [this message]
2007-01-26 1:29 ` Geoff Levand
2007-01-25 6:19 ` Arnd Bergmann
2007-01-25 13:32 ` Geert Uytterhoeven
2007-01-25 13:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169697245.24996.52.camel@localhost.localdomain \
--to=benh@kernel$(echo .)crashing.org \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox