Subject: Re: [PATCH] powermac: clean up PIC initialisation code

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 05 Feb 2007 12:41:48 +1100

> --- linux-2.6-git.orig/arch/powerpc/platforms/powermac/setup.c	2007-02-02 01:09:19.949914899 +0100
> +++ linux-2.6-git/arch/powerpc/platforms/powermac/setup.c	2007-02-02 01:09:30.366914899 +0100
> @@ -756,7 +756,11 @@ define_machine(powermac) {
>  	.setup_arch		= pmac_setup_arch,
>  	.init_early		= pmac_init_early,
>  	.show_cpuinfo		= pmac_show_cpuinfo,
> +#ifdef CONFIG_PPC32
>  	.init_IRQ		= pmac_pic_init,
> +#else
> +	.init_IRQ		= pmac_mpic_init,
> +#endif

Not fan of having an ifdef here... I'd rather have a pmac_pic_init()
that does the right thing, maybe in setup.c

Ben.