From: Will Schmidt <will_schmidt@vnet•ibm.com>
To: Nathan Lynch <ntl@pobox•com>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org, sfr@canb•auug.org.au
Subject: Re: [PATCH 1/2] [powerpc] export symbols for use by lparcfg
Date: Mon, 12 Mar 2007 17:05:42 -0500 [thread overview]
Message-ID: <1173737143.7716.22.camel@localhost> (raw)
In-Reply-To: <20070312202400.GE18478@localdomain>
On Mon, 2007-12-03 at 15:24 -0500, Nathan Lynch wrote:
> Will Schmidt wrote:
> >
> > Updates the Kconfig to allow lparcfg to be built as a module, and
> > add the necessary EXPORT_SYMBOLS needed for a successful build.
>
> Well, almost exactly a year ago lparcfg was changed to bool. Do the
> reasons for that change still stand?
Hi Nathan,
Thanks for pointing this out to me. I was not aware there was a
specific and deliberate change to bool from tristate. I thought it was
due to a sloppy change that neglected to export required symbols.
> commit 82dfdcae0d57c842e02f037758687eef42fb7af6
> Author: Paul Mackerras <paulus@samba•org>
> Date: Tue Mar 14 11:35:37 2006 +1100
>
> powerpc: Disallow lparcfg being a module
>
> The lparcfg code needs several things which are pretty arcane internal
> details and which we don't want to export, which means that lparcfg
> doesn't work when built as a module. This makes it a bool instead of
> a tristate in the Kconfig so that users can't try to build it as a
> module.
>
> > +EXPORT_SYMBOL_GPL(lppaca);
>
> > +EXPORT_PER_CPU_SYMBOL_GPL(cpu_usage_array);
>
> > +EXPORT_SYMBOL_GPL(vdso_data);
>
> Hmm, I don't think lparcfg needs to access vdso_data at all.
It does via the reference here:
partition_potential_processors = vdso_data->processorCount
>
> In pseries_lparcfg_data we have:
>
> lrdrp = get_property(rtas_node, "ibm,lrdr-capacity", NULL);
>
> if (lrdrp == NULL) {
> partition_potential_processors = vdso_data->processorCount;
> } else {
> partition_potential_processors = *(lrdrp + 4);
> }
>
> partition_active_processors = lparcfg_count_active_processors();
>
> But if there's no ibm,lrdr-capacity property then the system doesn't
> support adding processors, so partition_potential_processors should be
> equal to partition_active_processors.
next prev parent reply other threads:[~2007-03-12 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 19:21 [PATCH 1/2] [powerpc] export symbols for use by lparcfg Will Schmidt
2007-03-12 19:21 ` [PATCH 2/2] [powerpc] replace if-then-else with a switch statement Will Schmidt
2007-03-12 20:24 ` [PATCH 1/2] [powerpc] export symbols for use by lparcfg Nathan Lynch
2007-03-12 22:05 ` Will Schmidt [this message]
2007-03-12 22:14 ` Nathan Lynch
2007-03-12 21:32 ` Christoph Hellwig
2007-03-12 22:07 ` Will Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173737143.7716.22.camel@localhost \
--to=will_schmidt@vnet$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ntl@pobox$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox