Subject: Re: [PATCH 3/3] consolidate do_signal

From: Benjamin Herrenschmidt <[email-masked]>
Date: Mon, 04 Jun 2007 11:10:53 +1000

On Sun, 2007-06-03 at 09:59 +1000, Benjamin Herrenschmidt wrote:
> > +             if ((ka.sa.sa_flags & SA_ONSTACK) &&
> > +                 current->sas_ss_size && !
> on_sig_stack(regs->gpr[1]))
> > +                     newsp = current->sas_ss_sp +
> current->sas_ss_size;
> > +             else
> > +                     newsp = regs->gpr[1];
> 
> Hrm... some gratuituous differences in the signal stack handling.. I
> wonder if that hides a bug in one of the implementations...

Ok, so, that bit is actually a bit nicer on 64 bits, where there's a
get_sigframe() that handles this and is called by setup_rt_frame (which
you renamed to handle_rt_signal64).

(Though the actual implementation of get_sigframe() could use some
cleanup).

I'll do a patch on top of yours making that bit common.

Cheers,
Ben.