Subject: Re: [patch 2/6] cuimage for Bamboo board

From: Josh Boyer <[email-masked]>
Date: Mon, 03 Sep 2007 08:42:11 -0500

On Mon, 2007-09-03 at 11:01 +1000, David Gibson wrote:
> On Fri, Aug 31, 2007 at 03:04:51PM -0500, Josh Boyer wrote:
> > Add a cuboot wrapper for the Bamboo board.  This also removes some obsoleted
> > linker declarations that have been moved into ops.h
> > 
> > Signed-off-by: Josh Boyer <[email-masked]>
> 
> [snip]
> > --- linux-2.6.orig/arch/powerpc/boot/bamboo.c
> > +++ linux-2.6/arch/powerpc/boot/bamboo.c
> > @@ -24,8 +24,7 @@
> >  #include "4xx.h"
> >  #include "44x.h"
> >  
> > -extern char _dtb_start[];
> > -extern char _dtb_end[];
> > +static u8 *bamboo_mac0, *bamboo_mac1;
> >  
> >  static void bamboo_fixups(void)
> >  {
> > @@ -34,12 +33,16 @@ static void bamboo_fixups(void)
> >  	ibm440ep_fixup_clocks(sysclk, 11059200);
> >  	ibm4xx_fixup_memsize();
> >  	ibm4xx_quiesce_eth((u32 *)0xef600e00, (u32 *)0xef600f00);
> > +	if (bamboo_mac0 && bamboo_mac1)
> > +		dt_fixup_mac_addresses(bamboo_mac0, bamboo_mac1);
> 
> Bit ugly that you only set the MAC address for any ethernet if they're
> supplied for every ethernet.

Good point.  Will fix.

> >  	simple_alloc_init(_end, avail_ram, 32, 64);
> > -	bamboo_init();
> > +	bamboo_init(NULL, NULL);
> 
> There must surely be a way to get the MAC addresses out of OpenBIOS...

Probably.  I just need to find out where they are stored.

josh