Subject: Re: PowerPC: new EMAC driver typo fix

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 02 Oct 2007 10:10:33 +1000

On Mon, 2007-10-01 at 18:57 -0500, Josh Boyer wrote:
> On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote:
> > This looks like typo. Please, apply this patch to fix.
> > 
> > diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c
> > --- linux-2.6.orig/drivers/net/ibm_newemac/core.c	2007-10-01 17:23:35.000000000 +0400
> > +++ linux-2.6/drivers/net/ibm_newemac/core.c	2007-10-01 17:44:57.000000000 +0400
> > @@ -1232,9 +1232,9 @@ static inline int emac_xmit_finish(struc
> >  	 * instead
> >  	 */
> >  	if (emac_has_feature(dev, EMAC_FTR_EMAC4))
> > -		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> > -	else
> >  		out_be32(&p->tmr0, EMAC4_TMR0_XMIT);
> > +	else
> > +		out_be32(&p->tmr0, EMAC_TMR0_XMIT);
> > 
> >  	if (unlikely(++dev->tx_cnt == NUM_TX_BUFF)) {
> >  		netif_stop_queue(ndev);
> 
> No Signed-off-by: line.
> 
> The patch looks sane otherwise.  David, Ben, comments?

It does definitely look like a genuine typo so Acked by me.

Ben.