Subject: Re: [Linux-fbdev-devel] vga16fb doesn't build on powerpc (vgacon_remap_base)

From: "Antonino A. Daplas" <[email-masked]>
Date: Wed, 17 Oct 2007 05:31:54 +0800

On Tue, 2007-10-16 at 15:14 -0400, Joseph Fannin wrote:
> vga16fb is an available config option on powerpc, but it won't link
> with my .config:
> 
>     ERROR: "vgacon_remap_base" [drivers/video/vga16fb.ko] undefined!
> 
> 
> I'm guessing this is because include/asm-powerpc/vga.h declares
> vgacon_remap_base: 
> 
>     extern unsigned long vgacon_remap_base;
> 
> 
> ...but arch/powerpc/kernel/setup_32.c wraps the definition in an #ifdef:
> 
>     #ifdef CONFIG_VGA_CONSOLE

Perhaps #if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_FB_VGA16) ?

or

bool VGA_HARDWARE

#if CONFIG_VGA_HARDWARE
    unsigned long vgacon_remap_base;
    EXPORT_SYMBOL(vgacon_remap_base);
#endif

and for the Kconfig entry of vgacon and vga16fb

select VGA_HARDWARE if PPC32
(or depends on (VGA_HARDWARE && PPC32))

Tony