Subject: RE: [PATCH v2] Device tree bindings for Xilinx devices

From: Josh Boyer <[email-masked]>
Date: Tue, 16 Oct 2007 20:49:10 -0500

On Tue, 2007-10-16 at 16:23 -0700, Stephen Neuendorffer wrote:
> It occurs to me that the 'compatible' bindings should probably be the
> name of the preferred driver for the device. 
> 
> > +   l) Xilinx ML300 Framebuffer
> > +    - compatible : Must include "xilinx,ml300-fb"
> Should probably be 'xilinxfb', and probably shouldn't reference ML300 at
> all.
> 
> > +   n) Xilinx EMAC and Xilinx TEMAC
> > +
> > +   Xilinx Ethernet devices.  Uses common properties from 
> > other Ethernet
> > +   devices with the following constraints:
> > +   
> > +   Required properties:
> > +    - compatible : Must include one of: "xilinx,plb-temac",
> > +                   "xilinx,plb-emac", "xilinx-opb-emac"
> Should probably be just 'emac' and 'temac'.

You mean xilinx,emac and xilinx,temac, right?  emac and temac are too
generic by themselves.

josh