Subject: Re: [PATCH] NULL terminate the pci_device_ids in pasemi_edac

From: Michael Ellerman <[email-masked]>
Date: Fri, 19 Oct 2007 20:34:32 +1000

On Fri, 2007-10-19 at 01:47 -0500, Olof Johansson wrote:
> On Fri, Oct 19, 2007 at 03:07:22PM +1000, Stephen Rothwell wrote:
> > Fixes:
> > drivers/edac/pasemi_edac: struct pci_device_id is 32 bytes.  The last of 1 is:
> > 0x00 0x00 0x19 0x59 0x00 0x00 0xa0 0x0a 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff
> > 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> > FATAL: drivers/edac/pasemi_edac: struct pci_device_id is not terminated with a NULL entry!
> > 
> > Signed-off-by: Stephen Rothwell <[email-masked]>
> 
> Acked-by: Olof Johansson <[email-masked]>
> 
> Thanks for fixing this, Stephen. ID lists without termination can really
> cause weird problems at the most random times since it depends on how
> the kernel is built whether they do any (immediate) harm or not.

Kind of makes you wonder if some macro foo to automatically append the
NULL entry wouldn't be a good idea.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person