Subject: Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

From: Benjamin Herrenschmidt <[email-masked]>
Date: Tue, 23 Oct 2007 17:40:26 +1000

> So Ben suggested what we really want is two routines,
> of_get_pci_dev_node() and of_peek_pci_dev_node() - the former returning
> a refcounted copy and the latter allowing you to "peek" at the
> device_node as long as you own the pci_dev.
> 
> I'm not sure it's worth the churn really, so we should probably just
> document that pci_device_to_OF_node() is contrary, and any users that
> need a reference can take one explicitly.

Yeah, I pretty much made the same decision a couple of years ago which
is why it's still the way it is now :-)

Cheers,
Ben.