Subject: Re: [PATCH] Use of_get_next_child() in k2_sata_proc_info()

From: Michael Ellerman <[email-masked]>
Date: Wed, 24 Oct 2007 15:31:25 +1000

On Wed, 2007-10-24 at 15:01 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2007-10-24 at 14:25 +1000, Michael Ellerman wrote:
> > k2_sata_proc_info() uses its own hand-rolled loop to check a nodes
> > children for a property, this is not safe WRT refcounting, so fix it
> > to use of_get_next_child().
> > 
> > Signed-off-by: Michael Ellerman <[email-masked]>
> 
> Acked-by: Benjamin Herrenschmidt <[email-masked]>
> 
> (Pending you test boot it on one of our G5s first !)

As if I'd send untested patches !!

...

It just booted and seems happy.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person