Subject: Re: [PATCH] using mii-bitbang on different processor ports

From: Sergej Stepanov <[email-masked]>
Date: Tue, 30 Oct 2007 17:58:37 +0100

Hello Scott.
Thank you for reply.
Am Dienstag, den 30.10.2007, 11:32 -0500 schrieb Scott Wood:
> On Tue, Oct 30, 2007 at 05:09:19PM +0100, Sergej Stepanov wrote:

> You could just use of_iomap() for the second one, since we don't need
> the physical address for bus->id.
Nice tip.
Than it would be needless-------
				|
				\/
> > +			iounmap(bitbang->mdc.dir);
> > +			return -ENOMEM;
> 
> Please use the goto-style error handling that's used elsewhere in the
> function.
Regards
Sergej.